Fix not thrown exception #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! Could you also update the test cases to match the new behavior? https://github.com/twonote/radosgw-admin4j/actions/runs/7570697337/job/20639380354?pr=50#step:10:10879 |
|
I hope I fixed the tests) locally I don't have time to figure out how to run them( I also used google java format for tests |
|
Megred. Thank you for yor contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect to get an exception that the bucket is not found if it really does not exist when using the
setIndividualBucketQuotaandsetUserQuotamethodsIn the current implementation, the error is ignored and it looks like the setter was successful